Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(#10336): Storybook & Chromatic & msw #10365

Merged
merged 102 commits into from
Apr 4, 2023
Merged

build(#10336): Storybook & Chromatic & msw #10365

merged 102 commits into from
Apr 4, 2023

Conversation

acid-chicken
Copy link
Member

@acid-chicken acid-chicken commented Mar 19, 2023 •
edited
Loading

#10336 セットアップ作業用ブランチ

実行方法

Universal

Setup

cd path/to/packages/misskey-js
pnpm build
cd path/to/packages/frontend
pnpm tsc -p .storybook && (node .storybook/preload-locale.js & node .storybook/preload-theme.js)

Run

cd path/to/packages/frontend
node .storybook/generate.js && pnpm storybook dev

macOS & Linux

Setup

cd path/to/packages/misskey-js
pnpm build

Run

cd path/to/packages/frontend
pnpm storybook-dev

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Mar 19, 2023
@codecov
Copy link

codecov bot commented Mar 19, 2023 •
edited
Loading

Codecov Report

Merging #10365 (b91d831) into develop (58f3a2e) will increase coverage by 0.00%.
The diff coverage is 96.22%.

@@           Coverage Diff            @@
##           develop   #10365   +/-   ##
========================================
  Coverage    75.23%   75.24%           
========================================
  Files          883      883           
  Lines        86686    86716   +30     
  Branches      5903     5907    +4     
========================================
+ Hits         65219    65249   +30     
  Misses       21467    21467
Impacted Files Coverage Δ
packages/frontend/src/components/MkUrlPreview.vue 92.20% <0.00%> (ø)
packages/frontend/src/components/global/MkAcct.vue 100.00% <ø> (ø)
packages/frontend/src/scripts/achievements.ts 96.43% <66.66%> (+0.02%) ⬆️
packages/frontend/src/components/MkContextMenu.vue 100.00% <100.00%> (ø)
packages/frontend/src/components/MkMenu.vue 100.00% <100.00%> (ø)
packages/frontend/src/components/global/MkAd.vue 100.00% <100.00%> (ø)
...ckages/frontend/src/components/global/MkAvatar.vue 97.70% <100.00%> (+<0.01%) ⬆️
...ages/frontend/src/components/global/MkEllipsis.vue 100.00% <100.00%> (ø)
...kages/frontend/src/components/global/MkLoading.vue 100.00% <100.00%> (ø)
...ontend/src/components/global/MkPageHeader.tabs.vue 100.00% <100.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

acid-chicken
acid-chicken commented Mar 20, 2023
View reviewed changes
packages/frontend/.storybook/.gitignore Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

現時点ではこのファイルに書いてあるコマンドでストーリーを生成してから pnpm storybook dev して Storybook の画面を開くことができる

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vite] Internal server error: Failed to resolve import "../node_modules/storybook-addon-misskey-theme/preview" from "..\..\..\..\..\..\virtual:\@storybook\builder-vite\vite-app.js". Does the file exist?
が出た

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI は回ってるし謎
あとで調査します

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows 環境で再現した

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syuilo 多分直った

@acid-chicken acid-chicken changed the title build(#10336): Storybook & Chromatic build(#10336): Storybook & Chromatic & msw Mar 20, 2023
@acid-chicken acid-chicken force-pushed the storybook branch 2 times, most recently from 9525989 to 59865c3 Compare March 20, 2023 07:33
@acid-chicken acid-chicken dismissed a stale review March 20, 2023 13:16

Please don't submit reviews blindly.

@acid-chicken acid-chicken dismissed a stale review March 24, 2023 03:27

same

@misskey-dev misskey-dev deleted a comment from github-actions bot Apr 2, 2023
@misskey-dev misskey-dev deleted a comment from github-actions bot Apr 2, 2023
@misskey-dev misskey-dev deleted a comment from github-actions bot Apr 2, 2023
@misskey-dev misskey-dev deleted a comment from github-actions bot Apr 2, 2023
@acid-chicken
Copy link
Member Author

acid-chicken commented Apr 3, 2023 •
edited
Loading

とりあえずこの PR でやっておきたいことは完全に終わった（のでレビューお願いします）

syuilo
syuilo reviewed Apr 3, 2023
View reviewed changes
packages/frontend/src/pages/user/activity.following.vue
@@ -77,7 +77,7 @@ async function renderChart() {
barPercentage: 0.7,
categoryPercentage: 0.7,
fill: true,
} satisfies ChartDataset, extra);
}, extra);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

satisfies使えないの悲しいわね

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

benjamn/ast-types#935

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントでsatisfies使いたいけど使えない旨を残しておいてもらえると助かる

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done @ b91d831

@syuilo syuilo merged commit 38d0b62 into develop Apr 4, 2023
@syuilo syuilo deleted the storybook branch April 4, 2023 00:38
@syuilo
Copy link
Member

syuilo commented Apr 4, 2023

🙏🏻🙏🏻🙏🏻

@acid-chicken acid-chicken removed the request for review from EbiseLutica April 4, 2023 04:57
@acid-chicken acid-chicken mentioned this pull request Apr 4, 2023
Merged
4 tasks
@acid-chicken acid-chicken mentioned this pull request Dec 26, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syuilo syuilo syuilo left review comments

Assignees
No one assigned
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acid-chicken @syuilo